Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter/unicorn): add fixer to throw-new-error #5148

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Aug 23, 2024

No description provided.

@github-actions github-actions bot added the A-linter Area - Linter label Aug 23, 2024
Copy link
Collaborator Author

camc314 commented Aug 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Aug 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@camc314 camc314 marked this pull request as ready for review August 23, 2024 20:48
Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #5148 will not alter performance

Comparing c/08-23-feat_linter_add_fixer_to_throw-new-error_ (9f64fe0) with c/08-23-feat_linter_add_fixer_to_prefer-date-now_ (dcbceca)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac changed the title feat(linter) add fixer to throw-new-error feat(linter/unicorn): add fixer to throw-new-error Aug 23, 2024
@camc314 camc314 force-pushed the c/08-23-feat_linter_add_fixer_to_prefer-date-now_ branch from 3abd301 to dcbceca Compare August 24, 2024 09:26
@camc314 camc314 force-pushed the c/08-23-feat_linter_add_fixer_to_throw-new-error_ branch from 478ecdc to 9f64fe0 Compare August 24, 2024 09:26
@DonIsaac DonIsaac merged commit aa32a90 into c/08-23-feat_linter_add_fixer_to_prefer-date-now_ Aug 25, 2024
27 of 28 checks passed
@DonIsaac DonIsaac deleted the c/08-23-feat_linter_add_fixer_to_throw-new-error_ branch August 25, 2024 00:01
camc314 added a commit that referenced this pull request Aug 27, 2024
got merged into the wrong branch (#5148), hence setting to merge when ready (as was already approved)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants